Add descriptive labels to Footnote return links by rezrah · Pull Request #1211 · primer/brand

rezrah · 2025-12-17T20:04:13Z

Summary

Towards https://github.com/github/accessibility-audits/issues/14513

Expands the aria-label in return links to include children, per the recommendation made in the a11y audit.

Resolves a sev-2 accessibility bug.

List of notable changes:

added the item text to the aria-label
updated tests
added a changeset

What should reviewers focus on?

Check that the aria-label includes the Footnote.Item text

Steps to test:

Go to this (or any) Footnote story
Inspect return icon link, and verify that the aria-label includes the adjacent text

Supporting resources (related issues, external links, etc):

https://github.com/github/accessibility-audits/issues/14513

Contributor checklist:

All new and existing CI checks pass
Tests prove that the feature works and covers both happy and unhappy paths
Any drop in coverage, breaking changes or regressions have been documented above
UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
All developer debugging and non-functional logging has been removed
Related issues have been referenced in the PR description

Reviewer checklist:

Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
Check that tests prove the feature works and covers both happy and unhappy paths
Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before	After

changeset-bot · 2025-12-17T20:04:17Z

🦋 Changeset detected

Latest commit: 41750c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@primer/react-brand	Patch
@primer/brand-docs	Patch
@primer/brand-css	Patch
@primer/brand-primitives	Patch
@primer/brand-e2e	Patch
@primer/brand-fonts	Patch
@primer/brand-config	Patch
@primer/brand-storybook	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2025-12-17T20:06:15Z

🟢 No design token changes found

Copilot

Pull request overview

This PR enhances the accessibility of Footnote return links by adding descriptive labels that include the footnote content. The change addresses a severity-2 accessibility issue identified in an audit, ensuring screen readers announce more context when reading the back links.

Key changes:

Updated the aria-label attribute to include the footnote's text content alongside "Back to content"
Modified the corresponding test to verify the new aria-label format
Added a changeset documenting this accessibility improvement

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File	Description
`packages/react/src/Footnotes/Footnotes.tsx`	Modified aria-label to append children content to "Back to content"
`packages/react/src/Footnotes/Footnotes.test.tsx`	Updated test assertion to match new aria-label format and removed trailing space from test data
`.changeset/lucky-socks-carry.md`	Added changeset documenting the accessibility enhancement
`package-lock.json`	Version bumps across packages (0.60.1 → 0.61.0)

github-actions · 2025-12-17T20:08:04Z

🟢 Unit test coverage changes found

Unit test coverage has been updated through this PR.

Changes: 0 new tests, 0 removed tests, 1 improved, 0 decreased

Component/Hook	Statements	Functions	Branches	Change
`Footnotes`	~~95.2%~~ 95.5%	100.0%	92.3%	+0.2%

github-actions · 2025-12-17T20:10:09Z

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

danielguillan

Looks good!

rezrah · 2026-06-10T15:06:34Z

@copilot fix the merge conflict here please (merge in main)

Copilot · 2026-06-10T15:19:49Z

@copilot fix the merge conflict here please (merge in main)

Merged main into this branch and resolved the conflict in commit 22ea9420.

github-actions · 2026-06-19T15:06:13Z

🟢 Bundle size report

Check	Main	Branch	Change
UMD — full bundle (JS)	99.35 kB	99.46 kB	⬆️ +113 B (+0.1%)
UMD — full bundle (CSS)	65.46 kB	65.46 kB	🟢 No change
ESM — full bundle (JS + CSS)	1.49 MB	1.50 MB	⬆️ +2.95 kB (+0.2%)
ESM — tree-shaken simple (Button)	68.33 kB	68.33 kB	🟢 No change
ESM — tree-shaken complex (ActionMenu)	77.11 kB	77.11 kB	🟢 No change

…te-back-url

…d into rezrah/fix-footnote-back-url

add children to aria-label

9045e2f

rezrah requested a review from a team as a code owner December 17, 2025 20:04

Copilot AI review requested due to automatic review settings December 17, 2025 20:04

Copilot started reviewing on behalf of rezrah December 17, 2025 20:04 View session

Copilot AI reviewed Dec 17, 2025

View reviewed changes

Comment thread packages/react/src/Footnotes/Footnotes.tsx Outdated

Comment thread packages/react/src/Footnotes/Footnotes.test.tsx

rezrah temporarily deployed to github-pages December 17, 2025 20:08 — with GitHub Actions Inactive

rezrah requested a review from danielguillan December 17, 2025 20:11

handle react children

ddefceb

rezrah temporarily deployed to github-pages December 17, 2025 20:39 — with GitHub Actions Inactive

danielguillan approved these changes Dec 18, 2025

View reviewed changes

Copilot started work on behalf of rezrah June 10, 2026 15:06 View session

Merge origin/main into rezrah/fix-footnote-back-url

22ea942

Copilot finished work on behalf of rezrah June 10, 2026 15:20

Merge branch 'main' into rezrah/fix-footnote-back-url

ef31b0d

rezrah temporarily deployed to github-pages June 19, 2026 15:09 — with GitHub Actions Inactive

rezrah added 2 commits June 20, 2026 17:25

Merge branch 'main' of github.com:primer/brand into rezrah/fix-footno…

681ac60

…te-back-url

Merge branch 'rezrah/fix-footnote-back-url' of github.com:primer/bran…

41750c9

…d into rezrah/fix-footnote-back-url

rezrah temporarily deployed to github-pages June 20, 2026 16:42 — with GitHub Actions Inactive

rezrah merged commit 06c14a2 into main Jun 20, 2026
17 checks passed

rezrah deleted the rezrah/fix-footnote-back-url branch June 20, 2026 16:48

primer Bot mentioned this pull request Jun 20, 2026

Release tracking #1381

Merged

github-actions Bot mentioned this pull request Jul 6, 2026

New release available "@primer/react-brand@0.70.0" primer/brand-releases#41

Closed

22 tasks

Navigation Menu

Uh oh!

Add descriptive labels to Footnote return links - #1211

Add descriptive labels to Footnote return links#1211
rezrah merged 6 commits into
mainfrom
rezrah/fix-footnote-back-url

rezrah commented Dec 17, 2025 •

edited

Loading

Uh oh!

changeset-bot Bot commented Dec 17, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Dec 17, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Dec 17, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Dec 17, 2025 •

edited

Loading

Uh oh!

danielguillan left a comment

Uh oh!

rezrah commented Jun 10, 2026

Uh oh!

Copilot AI commented Jun 10, 2026

Uh oh!

github-actions Bot commented Jun 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

rezrah commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

List of notable changes:

What should reviewers focus on?

Steps to test:

Supporting resources (related issues, external links, etc):

Contributor checklist:

Reviewer checklist:

Screenshots:

Uh oh!

changeset-bot Bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 No design token changes found

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 Unit test coverage changes found

Uh oh!

github-actions Bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 No visual differences found

Uh oh!

danielguillan left a comment

Choose a reason for hiding this comment

Uh oh!

rezrah commented Jun 10, 2026

Uh oh!

Copilot AI commented Jun 10, 2026

Uh oh!

github-actions Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 Bundle size report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rezrah commented Dec 17, 2025 •

edited

Loading

changeset-bot Bot commented Dec 17, 2025 •

edited

Loading

github-actions Bot commented Dec 17, 2025 •

edited

Loading

github-actions Bot commented Dec 17, 2025 •

edited

Loading

github-actions Bot commented Dec 17, 2025 •

edited

Loading

github-actions Bot commented Jun 19, 2026 •

edited

Loading